tkalkirill commented on code in PR #4162:
URL: https://github.com/apache/ignite-3/pull/4162#discussion_r1698344749
##########
modules/network/src/main/java/org/apache/ignite/internal/network/DefaultMessagingService.java:
##########
@@ -516,10 +528,22 @@ private void handleStartingWithFirstHandler(
private static void logAndRethrowIfError(InNetworkObject obj, Throwable e)
{
if (e instanceof UnresolvableConsistentIdException && obj.message()
instanceof InvokeRequest) {
- LOG.info("onMessage() failed while processing {} from {} as the
sender has left the topology",
- obj.message(), obj.sender());
+ if (LOG.isDebugEnabled()) {
+ LOG.debug(
Review Comment:
Fix it
##########
modules/network/src/main/java/org/apache/ignite/internal/network/DefaultMessagingService.java:
##########
@@ -516,10 +528,22 @@ private void handleStartingWithFirstHandler(
private static void logAndRethrowIfError(InNetworkObject obj, Throwable e)
{
if (e instanceof UnresolvableConsistentIdException && obj.message()
instanceof InvokeRequest) {
- LOG.info("onMessage() failed while processing {} from {} as the
sender has left the topology",
- obj.message(), obj.sender());
+ if (LOG.isDebugEnabled()) {
+ LOG.debug(
+ "onMessage() failed while processing {} from {} as the
sender has left the topology",
+ obj.message(), obj.sender()
+ );
+ } else if (LOG.isInfoEnabled()) {
+ LOG.info(
+ "onMessage() failed while processing {} from {} as the
sender has left the topology",
+ obj.message().toStringForLightLogging(), obj.sender()
+ );
+ }
} else {
- LOG.error("onMessage() failed while processing {} from {}", e,
obj.message(), obj.sender());
+ LOG.error(
+ "onMessage() failed while processing {} from {}",
+ e, LOG.isDebugEnabled() ? obj.message() :
obj.message().toStringForLightLogging(), obj.sender()
Review Comment:
Fix it
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##########
@@ -597,7 +596,7 @@ private void handleThrowable(
"Recoverable error during the request occurred (will be
retried on the randomly selected node) "
+ "[request={}, peer={}, newPeer={}].",
err,
- sentRequest,
+ LOG.isDebugEnabled() ? sentRequest :
sentRequest.toStringForLightLogging(),
Review Comment:
Fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
