sanpwc commented on code in PR #4090:
URL: https://github.com/apache/ignite-3/pull/4090#discussion_r1705578453
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -762,16 +762,13 @@ public CompletableFuture<Replica> startReplica(
/**
* Creates and start new replica.
- * TODO: must be deleted or be private after
https://issues.apache.org/jira/browse/IGNITE-22373
*
* @param replicaGrpId Replication group id.
* @param storageIndexTracker Storage index tracker.
* @param newReplicaListenerFut Future that returns ready ReplicaListener
for replica creation.
* @return Future that promises ready new replica when done.
*/
- @VisibleForTesting
- @Deprecated
- public CompletableFuture<Replica> startReplica(
+ private CompletableFuture<Replica> startReplica(
Review Comment:
I mean that formally speaking this method is still @Deprecared and
@VisibleForTesting, thus it's incorrect to remove given annotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
