sanpwc commented on code in PR #4090:
URL: https://github.com/apache/ignite-3/pull/4090#discussion_r1705580705
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -295,7 +295,7 @@ public ReplicaManager(
Executor requestsExecutor,
LongSupplier idleSafeTimePropagationPeriodMsSupplier,
FailureProcessor failureProcessor,
- Marshaller raftCommandsMarshaller,
+ @Nullable Marshaller raftCommandsMarshaller,
Review Comment:
All I'm talking about is the fact that if you mark both fields as @Nullable
in ReplicaManager constructor you should also mark the fields both in
ReplicaManager and RaftGroupOptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
