sashapolo commented on code in PR #4190:
URL: https://github.com/apache/ignite-3/pull/4190#discussion_r1705955128
##########
modules/replicator/src/test/java/org/apache/ignite/internal/replicator/ReplicaManagerTest.java:
##########
@@ -109,12 +109,15 @@ void startReplicaManager(
var clock = new HybridClockImpl();
- requestsExecutor = new ThreadPoolExecutor(
- 0, 5,
- 0, TimeUnit.SECONDS,
+ ThreadPoolExecutor threadPoolExecutor = new ThreadPoolExecutor(
+ 5, 5,
+ 10, TimeUnit.SECONDS,
new LinkedBlockingQueue<>(),
NamedThreadFactory.create(nodeName, "partition-operations",
log)
);
+ threadPoolExecutor.allowCoreThreadTimeOut(true);
Review Comment:
Same question, I don't think we need to shutdown threads preemptively in
tests. Same applies to other similar places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
