rpuch commented on code in PR #4190:
URL: https://github.com/apache/ignite-3/pull/4190#discussion_r1706479181
##########
modules/network/src/main/java/org/apache/ignite/internal/network/netty/ConnectionManager.java:
##########
@@ -218,16 +218,19 @@ public ConnectionManager(
this.clientBootstrap = bootstrapFactory.createClientBootstrap();
- // We don't just use Executors#newSingleThreadExecutor() here because
it defines corePoolSize=1, so the maintenance thread will
+ // We don't just use Executors#newSingleThreadExecutor() here because
the maintenance thread will
// be kept alive forever, and we only need it from time to time, so it
seems a waste to keep the thread alive.
- connectionMaintenanceExecutor = new ThreadPoolExecutor(
- 0,
+ ThreadPoolExecutor maintenanceExecutor = new ThreadPoolExecutor(
Review Comment:
`newSingleThreadExecutor()` sets timeout to 0, so the thread will never be
let go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
