rpuch commented on code in PR #4005: URL: https://github.com/apache/ignite-3/pull/4005#discussion_r1714762247
########## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/RaftOptionsConfigurator.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.raft; + +/** + * This interface allows to inject RAFT options configuration. + * + * <p>This is the example of using it: + * <pre> + * RaftOptionsConfigurator raftOptionsConfigurator = options -> { + * RaftGroupOptions raftOptions = (RaftGroupOptions) options; + * + * raftOptions.setLogStorageFactory(logStorageFactory); + * raftOptions.serverDataPath(dataPath); + * }; + * </pre> + * TODO: https://issues.apache.org/jira/browse/IGNITE-18273 + */ +@FunctionalInterface +public interface RaftOptionsConfigurator { Review Comment: >The name comes from the action it performs - to configure raft parameters It configures group options, not overall raft options. There is a class called exactly `RaftOptions`, and the proposed naming creates confusion. Everyone who knows about the implementation (that is, most AI3 developers) would think about this class first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
