Cyrill commented on code in PR #4005:
URL: https://github.com/apache/ignite-3/pull/4005#discussion_r1713320964


##########
modules/placement-driver/build.gradle:
##########
@@ -57,6 +57,7 @@ dependencies {
     integrationTestImplementation project(':ignite-transactions')
     integrationTestImplementation project(':ignite-catalog')
     integrationTestImplementation project(':ignite-metrics')
+    integrationTestImplementation project(':ignite-runner')

Review Comment:
   It is to use ComponentWorkingDir to set up the tests (there is a way to 
replace ComponentWorkingDir with hardcoded values, but using the same pattern 
everywhere looks more consistent). 



##########
modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageMultipleNodesAbstractTest.java:
##########
@@ -130,6 +135,12 @@ private class Node {
 
         private final Loza raftManager;
 
+        private final LogStorageFactory defaultLogStorageFactory;
+
+        private final LogStorageFactory msLogStorageFactory;
+
+        private final LogStorageFactory cmgLogStorageFactory;

Review Comment:
   It is to be able to split raft logs of MS and CMG



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to