Vladsz83 commented on code in PR #11479:
URL: https://github.com/apache/ignite/pull/11479#discussion_r1717482266
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/BaseQueryContext.java:
##########
@@ -335,8 +337,31 @@ public static class Builder {
* @param frameworkCfg Framework config.
* @return Builder for chaining.
*/
- public Builder frameworkConfig(@NotNull FrameworkConfig frameworkCfg) {
- this.frameworkCfg = frameworkCfg;
+ public Builder frameworkConfig(@Nullable FrameworkConfig frameworkCfg)
{
+ if (frameworkCfg == null)
+ return this;
+
+ if (this.frameworkCfg != EMPTY_CONFIG) {
+ // Schema was set explicitely earlier.
+ SchemaPlus schema = this.frameworkCfg.getDefaultSchema();
+
+ this.frameworkCfg =
newConfigBuilder(frameworkCfg).defaultSchema(schema).build();
Review Comment:
Could be sinlge line. Up to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]