Vladsz83 commented on code in PR #11479:
URL: https://github.com/apache/ignite/pull/11479#discussion_r1717500547
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/PlannerTest.java:
##########
@@ -780,105 +772,29 @@ public void testMergeFilters() throws Exception {
*/
@Test
public void testJoinPushExpressionRule() throws Exception {
- IgniteTypeFactory f = new IgniteTypeFactory(IgniteTypeSystem.INSTANCE);
-
- TestTable emp = new TestTable(
- new RelDataTypeFactory.Builder(f)
- .add("ID", f.createJavaType(Integer.class))
- .add("NAME", f.createJavaType(String.class))
- .add("DEPTNO", f.createJavaType(Integer.class))
- .build()) {
-
- @Override public IgniteDistribution distribution() {
- return IgniteDistributions.broadcast();
- }
- };
-
- TestTable dept = new TestTable(
- new RelDataTypeFactory.Builder(f)
- .add("DEPTNO", f.createJavaType(Integer.class))
- .add("NAME", f.createJavaType(String.class))
- .build()) {
-
- @Override public IgniteDistribution distribution() {
- return IgniteDistributions.broadcast();
- }
- };
-
- IgniteSchema publicSchema = new IgniteSchema("PUBLIC");
-
- publicSchema.addTable("EMP", emp);
- publicSchema.addTable("DEPT", dept);
-
- SchemaPlus schema = createRootSchema(false)
- .add("PUBLIC", publicSchema);
+ IgniteSchema publicSchema = createSchema(
+ createTable("EMP", 100, IgniteDistributions.broadcast(),
+ "ID", INTEGER, "NAME", VARCHAR, "DEPTNO", INTEGER),
+ createTable("DEPT", 10, IgniteDistributions.broadcast(),
+ "DEPTNO", INTEGER, "NAME", VARCHAR)
+ );
- String sql = "select d.deptno, e.deptno " +
+ String sql = "select /*+ CNL_JOIN */ d.deptno, e.deptno " +
Review Comment:
Why CNL_JOIN now? To keep the order, maybe just ENFORCE_JOIN_ORDER ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
