rpuch commented on code in PR #4227:
URL: https://github.com/apache/ignite-3/pull/4227#discussion_r1721685864
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -513,13 +519,38 @@ private CompletableFuture<?>
processRequest(ReplicaRequest request, @Nullable Bo
return processGetEstimatedSizeRequest();
}
- HybridTimestamp opTsIfDirectRo = (request instanceof
ReadOnlyDirectReplicaRequest) ? clockService.now() : null;
+ @Nullable HybridTimestamp opTs = getTxOpTimestamp(request);
+ @Nullable HybridTimestamp opTsIfDirectRo = (request instanceof
ReadOnlyDirectReplicaRequest) ? opTs : null;
+ @Nullable HybridTimestamp txTs = getTxStartTimestamp(request);
+ if (txTs == null) {
Review Comment:
In the current code this is true, but if we change the code, we can
inadvertently break this implicit invariant. An assertion would help to make it
explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
