rpuch commented on code in PR #4227:
URL: https://github.com/apache/ignite-3/pull/4227#discussion_r1723149624
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -1579,23 +1579,23 @@ private Publisher<BinaryRow> readOnlyScan(
return new PartitionScanPublisher<>(new
ReadOnlyInflightBatchRequestTracker(transactionInflights, txId)) {
@Override
protected CompletableFuture<Collection<BinaryRow>>
retrieveBatch(Long scanId, Integer batchSize) {
- ReadOnlyScanRetrieveBatchReplicaRequest request =
TABLE_MESSAGES_FACTORY.readOnlyScanRetrieveBatchReplicaRequest()
- .groupId(serializeTablePartitionId(tablePartitionId))
- .tableId(tableId)
- .readTimestamp(readTimestamp)
- .transactionId(txId)
- .scanId(scanId)
- .batchSize(batchSize)
- .indexToUse(indexId)
- .exactKey(binaryTupleMessage(exactKey))
- .lowerBoundPrefix(binaryTupleMessage(lowerBound))
- .upperBoundPrefix(binaryTupleMessage(upperBound))
- .flags(flags)
- .columnsToInclude(columnsToInclude)
- .coordinatorId(txCoordinatorId)
- .build();
+ ReadOnlyScanRetrieveBatchReplicaRequest request =
TABLE_MESSAGES_FACTORY.readOnlyScanRetrieveBatchReplicaRequest()
Review Comment:
Is this too many indents again? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
