tkalkirill commented on code in PR #4437: URL: https://github.com/apache/ignite-3/pull/4437#discussion_r1773192084
########## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointPages.java: ########## @@ -17,75 +17,174 @@ package org.apache.ignite.internal.pagememory.persistence.checkpoint; +import static org.apache.ignite.internal.pagememory.persistence.checkpoint.CheckpointState.PAGES_SORTED; import static org.apache.ignite.internal.util.IgniteUtils.getUninterruptibly; import java.util.Set; import java.util.concurrent.CancellationException; -import java.util.concurrent.CompletableFuture; import java.util.concurrent.ExecutionException; -import org.apache.ignite.internal.lang.IgniteInternalCheckedException; import org.apache.ignite.internal.pagememory.FullPageId; +import org.apache.ignite.internal.pagememory.persistence.GroupPartitionId; +import org.apache.ignite.internal.pagememory.persistence.PersistentPageMemory; +import org.apache.ignite.internal.pagememory.persistence.store.FilePageStore; +import org.apache.ignite.internal.pagememory.persistence.store.FilePageStoreManager; +import org.apache.ignite.internal.storage.StorageException; +import org.jetbrains.annotations.Nullable; /** - * View of pages which should be stored during current checkpoint. + * Class contains dirty pages of the segment that will need to be written at a checkpoint or page replacement. It also contains helper + * methods before writing pages. + * + * <p>For correct parallel operation of the checkpoint writer and page replacement, external synchronization must be used, for example, Review Comment: I don't know what else to add here, I'm saying that for example you can use segment locks. Tell me what exactly you don't like? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
