tkalkirill commented on code in PR #4437:
URL: https://github.com/apache/ignite-3/pull/4437#discussion_r1773166801
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java:
##########
@@ -1511,25 +1526,28 @@ public boolean tryToRemovePage(FullPageId fullPageId,
long absPtr) throws Ignite
if (isDirty(absPtr)) {
CheckpointPages checkpointPages = this.checkpointPages;
- // Can evict a dirty page only if should be written by a
checkpoint.
- // These pages does not have tmp buffer.
- if (checkpointPages != null &&
checkpointPages.allowToSave(fullPageId)) {
- WriteDirtyPage writeDirtyPage =
delayedPageReplacementTracker.delayedPageWrite();
-
- writeDirtyPage.write(PersistentPageMemory.this,
fullPageId, wrapPointer(absPtr + PAGE_OVERHEAD, pageSize()));
-
- setDirty(fullPageId, absPtr, false, true);
+ // Can replace a dirty page only if should be written by a
checkpoint.
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
