timoninmaxim commented on code in PR #11597:
URL: https://github.com/apache/ignite/pull/11597#discussion_r1803185750
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/incremental/IncrementalSnapshotCheckBeforeRestoreTest.java:
##########
@@ -275,7 +275,7 @@ public void testNoIncrementalSnapshotMetaNotFound() throws
Exception {
meta.snapshotName() + "1",
meta.incrementIndex(),
meta.consistentId(),
- null,
+ null, meta.creationTimeMillis(),
Review Comment:
each argument in this call is placed on new line
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/systemview/walker/SnapshotViewWalker.java:
##########
@@ -47,10 +48,11 @@ public class SnapshotViewWalker implements
SystemViewRowAttributeWalker<Snapshot
v.accept(4, "snapshotRecordSegment", Long.class,
row.snapshotRecordSegment());
v.accept(5, "incrementIndex", Integer.class, row.incrementIndex());
v.accept(6, "type", String.class, row.type());
+ v.accept(7, "creationTimeMillis", Long.class,
row.creationTimeMillis());
Review Comment:
Add info about the field to ignite docs.
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/systemview/walker/SnapshotViewWalker.java:
##########
@@ -36,6 +36,7 @@ public class SnapshotViewWalker implements
SystemViewRowAttributeWalker<Snapshot
v.accept(4, "snapshotRecordSegment", Long.class);
v.accept(5, "incrementIndex", Integer.class);
v.accept(6, "type", String.class);
+ v.accept(7, "creationTimeMillis", Long.class);
Review Comment:
Names of similar fields in other views don't contain "Millis" suffix
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IncrementalSnapshotMetadata.java:
##########
@@ -62,20 +66,23 @@ public class IncrementalSnapshotMetadata implements
Serializable {
* @param consId Consistent id of a node to which this metadata relates.
* @param folderName Directory name which stores the data files.
* @param incSnpRec Pointer to {@link IncrementalSnapshotFinishRecord}.
+ * @param creationTimeMillis Timestamp of the snapshot creation.
*/
public IncrementalSnapshotMetadata(
UUID rqId,
String snpName,
int incIdx,
String consId,
String folderName,
+ @Nullable long creationTimeMillis,
Review Comment:
primitive types couldn't be nullable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
