timoninmaxim commented on code in PR #11597:
URL: https://github.com/apache/ignite/pull/11597#discussion_r1803649475
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IncrementalSnapshotMetadata.java:
##########
@@ -52,6 +52,9 @@ public class IncrementalSnapshotMetadata implements
Serializable {
/** Name of the folder that contains snapshot data. */
private final String folderName;
+ /** Creation timestamp in milliseconds since Unix epoch. */
+ private final long creationTimeMillis;
Review Comment:
`creationTime`
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/incremental/IncrementalSnapshotCheckBeforeRestoreTest.java:
##########
@@ -307,7 +308,7 @@ public void testIncrementIndexMismatch() throws Exception {
meta.snapshotName(),
meta.incrementIndex() + 1,
meta.consistentId(),
- null,
+ null, meta.creationTimeMillis(),
Review Comment:
Set arg on new line
##########
docs/_docs/monitoring-metrics/system-views.adoc:
##########
@@ -1009,4 +1009,5 @@ The SNAPSHOT view exposes information about local
snapshots.
| SNAPSHOT_RECORD_SEGMENT | BIGINT | Index of WAL segment containing
snapshot's WAL record.
| INCREMENT_INDEX | INTEGER | Incremental snapshot index.
| TYPE | VARCHAR | Type of snapshot - full or incremental.
+| CREATION_TIME | long | Snapshot creation time.
Review Comment:
Type naming should be consistent in the snapshot view block.
##########
modules/core/src/main/java/org/apache/ignite/spi/systemview/view/SnapshotView.java:
##########
@@ -143,6 +147,14 @@ public String type() {
return type.name();
}
+ /**
+ * @return Creation timestamp in milliseconds since Unix epoch.
+ */
+ @Order(7)
+ public Long creationTimeMillis() {
+ return creationTimeMillis != null && creationTimeMillis != 0 ?
creationTimeMillis : null;
Review Comment:
it never can be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
