ibessonov commented on code in PR #4687:
URL: https://github.com/apache/ignite-3/pull/4687#discussion_r1832228039
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/WatchProcessor.java:
##########
@@ -416,7 +427,11 @@ CompletableFuture<Void> notifyUpdateRevisionListeners(long
newRevision) {
void updateCompactionRevision(long compactionRevision, HybridTimestamp
time) {
notificationFuture = notificationFuture
.thenRunAsync(() -> {
- compactionRevisionUpdateListeners.forEach(listener ->
listener.onUpdate(compactionRevision));
+ if (compactionRevision > this.compactionRevision) {
Review Comment:
Can't we make this check in the storage and not propagate the
`updateCompactionRevision` event if it fails? It would make more sense to me
this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
