ibessonov commented on code in PR #4687:
URL: https://github.com/apache/ignite-3/pull/4687#discussion_r1832249486
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/WatchProcessor.java:
##########
@@ -416,7 +427,11 @@ CompletableFuture<Void> notifyUpdateRevisionListeners(long
newRevision) {
void updateCompactionRevision(long compactionRevision, HybridTimestamp
time) {
notificationFuture = notificationFuture
.thenRunAsync(() -> {
- compactionRevisionUpdateListeners.forEach(listener ->
listener.onUpdate(compactionRevision));
+ if (compactionRevision > this.compactionRevision) {
Review Comment:
We already store that revision in the storage, we can read it back or store
in the field, that's true. My question is more about "why would we notify
somebody about the event that we know is not needed", so I strongly suggest
moving this check to the storage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
