maksaska commented on code in PR #11793:
URL: https://github.com/apache/ignite/pull/11793#discussion_r1912442227
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/performancestatistics/PerformanceStatisticsThinClientTest.java:
##########
@@ -169,6 +176,10 @@ public void testCacheOperation() throws Exception {
checkCacheOperation(CACHE_REMOVE_ALL, cache ->
cache.removeAll(Collections.singleton(3)));
checkCacheOperation(CACHE_GET_AND_REMOVE, cache ->
cache.getAndRemove(5));
+
+ checkCacheOperation(CACHE_PUT_ALL_CONFLICT,
putAllConflict(Collections.singletonMap(6, 1)));
Review Comment:
Yes, you'r right. There are too many API calls for only one test. I
refactored this part, and moved my code to separete test methods as you
proposed.
As for the second proposal, I see what you mean. Fixed it
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/performancestatistics/PerformanceStatisticsThinClientTest.java:
##########
@@ -169,6 +176,10 @@ public void testCacheOperation() throws Exception {
checkCacheOperation(CACHE_REMOVE_ALL, cache ->
cache.removeAll(Collections.singleton(3)));
checkCacheOperation(CACHE_GET_AND_REMOVE, cache ->
cache.getAndRemove(5));
+
+ checkCacheOperation(CACHE_PUT_ALL_CONFLICT,
putAllConflict(Collections.singletonMap(6, 1)));
+
+ checkCacheOperation(CACHE_REMOVE_ALL_CONFLICT,
removeAllConflict(Collections.singleton(6)));
Review Comment:
Fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
