oleg-vlsk commented on code in PR #11793:
URL: https://github.com/apache/ignite/pull/11793#discussion_r1915934895


##########
modules/core/src/test/java/org/apache/ignite/internal/processors/performancestatistics/PerformanceStatisticsThinClientTest.java:
##########
@@ -171,6 +178,62 @@ public void testCacheOperation() throws Exception {
         checkCacheOperation(CACHE_GET_AND_REMOVE, cache -> 
cache.getAndRemove(5));
     }
 
+    /**
+     * Cache {@link TcpClientCache#putAllConflict} and {@link 
TcpClientCache#removeAllConflict} operations performed.
+     * @throws Exception If failed.
+     */
+    @Test
+    public void testCacheAllConflictOperations() throws Exception {
+        checkCacheAllConflictOperations(false);

Review Comment:
   Looks much better now, but I believe that moving each individual check into 
its own test method would make it even more convenient. Please consider adding 
the operation type argument to `checkCacheAllConflictOperations` so that it can 
be used for all four test methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to