sanpwc commented on code in PR #4902:
URL: https://github.com/apache/ignite-3/pull/4902#discussion_r1916980460
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/TxManager.java:
##########
@@ -37,45 +35,51 @@
*/
public interface TxManager extends IgniteComponent {
/**
- * Starts a read-write transaction coordinated by a local node.
+ * Starts an implicit read-write transaction coordinated by a local node.
*
* @param timestampTracker Observable timestamp tracker is used to track a
timestamp for either read-write or read-only
* transaction execution. The tracker is also used to determine
the read timestamp for read-only transactions.
- * @param implicit Whether the transaction is implicit or not.
* @return The transaction.
*/
- InternalTransaction begin(HybridTimestampTracker timestampTracker, boolean
implicit);
+ default InternalTransaction beginImplicitRw(HybridTimestampTracker
timestampTracker) {
+ return beginImplicit(timestampTracker, false);
+ }
/**
- * Starts either read-write or read-only transaction, depending on {@code
readOnly} parameter value. The transaction has
- * {@link TxPriority#NORMAL} priority.
+ * Starts an implicit read-write transaction coordinated by a local node.
*
* @param timestampTracker Observable timestamp tracker is used to track a
timestamp for either read-write or read-only
- * transaction execution. The tracker is also used to determine
the read timestamp for read-only transactions. Each client
- * should pass its own tracker to provide linearizability between
read-write and read-only transactions started by this client.
- * @param implicit Whether the transaction is implicit or not.
+ * transaction execution. The tracker is also used to determine
the read timestamp for read-only transactions.
* @param readOnly {@code true} in order to start a read-only transaction,
{@code false} in order to start read-write one.
* Calling begin with readOnly {@code false} is an equivalent of
TxManager#begin().
Review Comment:
Do we still have TxManager.begin()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
