rpuch commented on code in PR #4902:
URL: https://github.com/apache/ignite-3/pull/4902#discussion_r1918879416
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxManagerImpl.java:
##########
@@ -415,17 +455,40 @@ public InternalTransaction begin(
try {
CompletableFuture<Void> txFuture = new CompletableFuture<>();
+
+ var transaction = new ReadOnlyTransactionImpl(this,
timestampTracker, txId, localNodeId, implicit, readTimestamp, txFuture);
+
+ // Implicit transactions are finished as soon as their
operation/query is finished, they cannot be abandoned, so there is
+ // no need to register them.
Review Comment:
Split this to a separate issue, added a TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
