sanpwc commented on code in PR #5159:
URL: https://github.com/apache/ignite-3/pull/5159#discussion_r1944564522
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -413,6 +423,8 @@ private CompletableFuture<Void>
calculateZoneAssignmentsAndCreateReplicationNode
return inBusyLockAsync(busyLock, () -> {
int zoneId = zoneDescriptor.id();
+ zoneResourcesManager.registerZonePartitionCount(zoneId,
zoneDescriptor.partitions());
Review Comment:
I don't like such approach.
What about using
`catalogMgr.activeCatalog(metaStorageMgr.timestampByRevisionLocally(revision).longValue()).zone(zonePartitionId.zoneId()).partitions();`
in order to retrieve partitions count in
`PartitionReplicaLifecycleManager#createZonePartitionReplicationNode` and thus
propagating the count to ZoneResourcesManager#getOrCreatePartitionTxStateStorage
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
