rpuch commented on code in PR #5159:
URL: https://github.com/apache/ignite-3/pull/5159#discussion_r1944579738
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -413,6 +423,8 @@ private CompletableFuture<Void>
calculateZoneAssignmentsAndCreateReplicationNode
return inBusyLockAsync(busyLock, () -> {
int zoneId = zoneDescriptor.id();
+ zoneResourcesManager.registerZonePartitionCount(zoneId,
zoneDescriptor.partitions());
Review Comment:
1. The timestamp on MS entry for a catalog update is not the same as
activation timestamp of the catalog update
2. This seems really fragile
3. We could probably get into trouble with MS compaction
Current approach is simple and solves the task at hand. Also, it doesn't
introduce races. Why don't you like it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
