sanpwc commented on code in PR #5187:
URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1946813234
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java:
##########
@@ -103,18 +133,23 @@ public void
onWrite(Iterator<CommandClosure<WriteCommand>> iterator) {
private void processWriteCommand(CommandClosure<WriteCommand> clo) {
Command command = clo.command();
- if (command instanceof FinishTxCommand) {
- FinishTxCommand cmd = (FinishTxCommand) command;
+ long commandIndex = clo.index();
+ long commandTerm = clo.term();
+ @Nullable HybridTimestamp safeTimestamp = clo.safeTimestamp();
+ assert safeTimestamp == null || command instanceof
SafeTimePropagatingCommand : command;
+
+ IgniteBiTuple<Serializable, Boolean> result = null;
- clo.result(new TransactionResult(cmd.commit() ? COMMITTED :
ABORTED, cmd.commitTimestamp()));
+ if (command instanceof FinishTxCommand) {
+ result =
finishTxCommandHandler.handleFinishTxCommand((FinishTxCommand) command,
commandIndex, commandTerm);
Review Comment:
Should we rename handleFinishTxCommand() to just handle()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
