sanpwc commented on code in PR #5187:
URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1946836687
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java:
##########
@@ -124,6 +159,24 @@ private void
processWriteCommand(CommandClosure<WriteCommand> clo) {
clo.result(null);
}
+
+ // result == null means that the command either was not handled by
anyone (and clo.result() is called) or
+ // that it was delegated to a table processor (which called
clo.result()).
+
Review Comment:
Unnecessary blank line and I don't really like the dualism of result and
closure as return value. Don't have any good ideas from scratch about how to
fix it though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
