AMashenkov commented on code in PR #5686:
URL: https://github.com/apache/ignite-3/pull/5686#discussion_r2073006378


##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/util/StorageUtils.java:
##########
@@ -291,4 +292,19 @@ public static BinaryTupleComparator 
binaryTupleComparator(List<StorageSortedInde
 
         return new BinaryTupleComparator(columnCollation, columnTypes);
     }
+
+    /**
+     * Creates a comparator for a Sorted Index identified by the given columns 
descriptors.
+     */
+    public static PartialBinaryTupleComparator 
partialBinaryTupleComparator(List<StorageSortedIndexColumnDescriptor> columns) {
+        List<CatalogColumnCollation> columnCollation = new 
ArrayList<>(columns.size());
+        List<NativeType> columnTypes = new ArrayList<>(columns.size());
+
+        for (StorageSortedIndexColumnDescriptor col : columns) {
+            columnCollation.add(CatalogColumnCollation.get(col.asc(), 
!col.asc()));

Review Comment:
   We don't have null ordering in StorageSortedIndexDescriptor
    https://issues.apache.org/jira/browse/IGNITE-21672



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to