AMashenkov commented on code in PR #5870:
URL: https://github.com/apache/ignite-3/pull/5870#discussion_r2104606237
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/Column.java:
##########
@@ -205,8 +205,12 @@ public int hashCode() {
* @param val Object to validate.
*/
public void validate(@Nullable Object val) {
- if (val == null && !nullable) {
- throw new
SchemaMismatchException(nullConstraintViolationMessage(name));
+ if (val == null) {
Review Comment:
I don't like this method.
We should validate value range the same way in SQL and in KV.
Can we check here only typeSpec equality (+ maybe nullability), and then
pass `val` object to `NativeType.validate` method as
`Column.type.validate(val);`
NativeType implementations could override the method to check bounds or
length or whatever else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
