zstan commented on code in PR #5870:
URL: https://github.com/apache/ignite-3/pull/5870#discussion_r2104680344


##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/DefaultValue.java:
##########
@@ -138,12 +138,12 @@ public static class ConstantValue extends DefaultValue {
         private ConstantValue(@Nullable Object value) {
             super(Type.CONSTANT);
 
-            NativeType nativeType = NativeTypes.fromObject(value);
+            NativeType type0 = NativeTypes.fromObject(value);

Review Comment:
   I don\`t like this idea - to implement huge method for only this one case, 
anyway such request is beyond the scope of issue, previous implementation was 
the same



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to