AMashenkov commented on code in PR #6057:
URL: https://github.com/apache/ignite-3/pull/6057#discussion_r2158617153
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/ItDateTimeCastFormatTest.java:
##########
@@ -218,29 +216,27 @@ public void timeUpdateFromLiteral(DateTimeArgs<LocalTime>
args) {
if (args.value != null) {
assertQuery("SELECT time0_col FROM datetime_cols WHERE id = 1")
- .returns(args.value)
+ // We are writing to time0_col, so we should expect a time
w/o a fractional part.
Review Comment:
Let's create a ticket to support precisions greater than 3 and add a TODO
here,
to not forget revisiting these tests when the issue will be fixes.
Also, truncating arguments in generator method `@MethodSource("time")` may
be more convenient. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
