xtern commented on code in PR #6057:
URL: https://github.com/apache/ignite-3/pull/6057#discussion_r2158929190
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/ItDateTimeCastFormatTest.java:
##########
@@ -218,29 +216,27 @@ public void timeUpdateFromLiteral(DateTimeArgs<LocalTime>
args) {
if (args.value != null) {
assertQuery("SELECT time0_col FROM datetime_cols WHERE id = 1")
- .returns(args.value)
+ // We are writing to time0_col, so we should expect a time
w/o a fractional part.
Review Comment:
> Let's create a ticket to support precisions greater than 3
We have https://issues.apache.org/jira/browse/IGNITE-19162 and several TODOs
in our code base with it.
> add a TODO here
It's not relevant to sub-millis support, we have a column TIME(0) but
updating it to a value with milliseconds. After this patch millis are truncated
from the result value.
> truncating arguments in generator method @MethodSource("time") may be more
convenient.
Agreed, but the arguments from the "time" method are also used for other
tests that expect milliseconds as a result :pensive:
The good solution - merge args from "time" with "timeWIthPrecision" and
remove such excessive tests, but I'm too lazy... but if you insist, I'll try to
combine them :pensive:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
