lowka commented on code in PR #6305:
URL: https://github.com/apache/ignite-3/pull/6305#discussion_r2228220941
##########
modules/runner/src/test/java/org/apache/ignite/internal/configuration/compatibility/framework/ConfigurationTreeComparatorSelfTest.java:
##########
@@ -460,12 +561,55 @@ private static ConfigNode createRoot(String name) {
return ConfigNode.createRoot(name, Object.class,
ConfigurationType.LOCAL, true);
}
- private static ConfigNode createChild(ConfigNode root1, String name) {
+ private static ConfigNode createNode(String name, String className) {
+ return createNode(name, className, Set.of(), List.of());
+ }
+
+ private static ConfigNode createNode(String name, String className,
Set<String> legacyNames, List<String> deletedPrefixes) {
return new ConfigNode(
- root1,
+ null,
+ Map.of(Attributes.NAME, name, Attributes.CLASS, className),
+ List.of(),
+ EnumSet.noneOf(Flags.class),
+ legacyNames,
+ deletedPrefixes
+ );
+ }
+
+ private static ConfigNode createChild(ConfigNode root, String name) {
+ return new ConfigNode(
+ root,
Map.of(ConfigNode.Attributes.NAME, name, Attributes.CLASS,
int.class.getCanonicalName()),
List.of(),
- EnumSet.of(Flags.IS_VALUE)
+ EnumSet.of(Flags.IS_VALUE, Flags.HAS_DEFAULT)
+ );
+ }
+
+ private static ConfigNode createChild(String name) {
+ return createChild(name, Set.of(), Set.of(), List.of());
+ }
+
+ private static ConfigNode createChild(String name, Set<Flags> flags) {
+ return createChild(name, flags, Set.of(), List.of());
+ }
+
+ private static ConfigNode createChild(String name, Set<Flags> flags,
Set<String> legacyNames, List<String> deletedPrefixes) {
+ Set<Flags> valueFlags = new HashSet<>();
+ valueFlags.add(Flags.IS_VALUE);
Review Comment:
Fixed. Code doesn't add any presets.
Removed `createNode`, replacing it with `createChild`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
