lowka commented on code in PR #6305:
URL: https://github.com/apache/ignite-3/pull/6305#discussion_r2228273909


##########
modules/runner/src/test/java/org/apache/ignite/internal/configuration/compatibility/framework/ConfigNode.java:
##########
@@ -153,11 +153,18 @@ public String type() {
         return attributes.get(Attributes.CLASS);
     }
 
+    /**
+     * Returns flags for this node.
+     */
+    public Set<Flags> flags() {
+        return flags;
+    }
+
     /**
      * Returns the child nodes of this node.
      */
-    public Collection<ConfigNode> childNodes() {
-        return childNodeMap.values();
+    public Map<String, Node> children() {
+        return childNodeMap;

Review Comment:
   It looks like moving an attribute from one place to another -  instead of 
having a map of children, we remove a map and add the name property to the Node 
class. What is a difference?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to