rpuch commented on code in PR #6308: URL: https://github.com/apache/ignite-3/pull/6308#discussion_r2230327127
########## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/RawRaftNodeId.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.raft; + +import java.util.Objects; + +/** + * Raw Raft node ID. Review Comment: I renamed it `Row` -> `Stored`. I also replaced peerIndex with a `Peer` instance (as it can be restored). But the original groupId object cannot be restored from what we have in storage (we don't know the type of it, for example), and this gives the reason why this class was introduced: we cannot restore the original `RaftNodeId` from what we have in storage. ########## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/RawRaftNodeId.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.raft; + +import java.util.Objects; + +/** + * Raw Raft node ID. Review Comment: I renamed it `Raw` -> `Stored`. I also replaced peerIndex with a `Peer` instance (as it can be restored). But the original groupId object cannot be restored from what we have in storage (we don't know the type of it, for example), and this gives the reason why this class was introduced: we cannot restore the original `RaftNodeId` from what we have in storage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
