oleg-zinovev commented on code in PR #12096:
URL: https://github.com/apache/ignite/pull/12096#discussion_r2249249633
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/LogicalRelImplementor.java:
##########
@@ -882,6 +886,31 @@ else if (rel instanceof Intersect)
return node;
}
+ /** {@inheritDoc} */
+ @Override public Node<Row> visit(IgniteWindow rel) {
+ RelDataType outType = rel.getRowType();
+ RelDataType inputType = rel.getInput().getRowType();
+
+ List<Integer> grpKeys = rel.getGroup().keys.toList();
+ RelCollation collation = rel.collation();
+
+ assert collation.getFieldCollations().size() >= grpKeys.size();
+ Comparator<Row> partCmp =
expressionFactory.comparator(TraitUtils.createCollation(grpKeys));
+
+ List<AggregateCall> aggCalls = rel.getGroup().getAggregateCalls(rel);
+ Supplier<WindowPartition<Row>> frameFactory =
expressionFactory.windowFrameFactory(rel.getGroup(), aggCalls, inputType,
false);
Review Comment:
Thank you for the feedback.
Initially, I had two implementations of IgniteWindow, but then I replaced
them with one using a streaming flag. However, I missed passing the flag to the
factory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
