oleg-zinovev commented on code in PR #12096:
URL: https://github.com/apache/ignite/pull/12096#discussion_r2253989716
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/externalize/RelJson.java:
##########
@@ -889,27 +913,28 @@ private Object toJson(RexNode node) {
}
/** */
- private Object toJson(RexWindow window) {
+ private Object toJson(Window.Group group) {
Map<String, Object> map = map();
- if (!window.partitionKeys.isEmpty())
- map.put("partition", toJson(window.partitionKeys));
- if (!window.orderKeys.isEmpty())
- map.put("order", toJson(window.orderKeys));
- if (window.getLowerBound() == null) {
+ map.put("calls", toJson(group.aggCalls));
+ if (!group.keys.isEmpty())
+ map.put("partition", toJson(group.keys));
+ if (!group.orderKeys.getKeys().isEmpty())
+ map.put("order", toJson(group.orderKeys));
+ if (group.lowerBound == null) {
Review Comment:
Good point. I think I just copied the serialization logic of the Over
expression. I will review this part of the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
