Cyrill commented on code in PR #6408:
URL: https://github.com/apache/ignite-3/pull/6408#discussion_r2287464341
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java:
##########
@@ -979,10 +1024,10 @@ private CompletableFuture<Void>
updateLearnersSerially(CmgRaftService service, l
return service.updateLearners(term);
}
})
- .whenComplete((unused, throwable) -> {
- if (throwable != null) {
- LOG.error("Failed to reset learners", throwable);
- }
+ .exceptionally(e -> {
+ LOG.warn("Failed to update learners for term {}", e,
term);
Review Comment:
Before this change we neither waited on nor checked the status of this
future. Now we wait for the the previous one to finish but again, ignoring the
result. In other words, this behavior is left intact.
The future is likely to fail if the majority is down, otherwise we expect
the happy path. And the 'majority down' is going to be addressed in a separate
topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
