sanpwc commented on code in PR #6408:
URL: https://github.com/apache/ignite-3/pull/6408#discussion_r2288005441
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java:
##########
@@ -979,10 +1024,10 @@ private CompletableFuture<Void>
updateLearnersSerially(CmgRaftService service, l
return service.updateLearners(term);
}
})
- .whenComplete((unused, throwable) -> {
- if (throwable != null) {
- LOG.error("Failed to reset learners", throwable);
- }
+ .exceptionally(e -> {
+ LOG.warn("Failed to update learners for term {}", e,
term);
Review Comment:
Proposed solution looks fine to me.
> Does this deserve a TODO in code?
I don't think that there's an epic. We may create it though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
