adityamukho commented on code in PR #6774:
URL: https://github.com/apache/ignite-3/pull/6774#discussion_r2431682743
##########
modules/compatibility-tests/src/testFixtures/java/org/apache/ignite/internal/IgniteCluster.java:
##########
@@ -294,7 +300,15 @@ public List<Ignite> nodes() {
return nodes;
}
- private ServerRegistration startEmbeddedNode(
+ /**
+ * Starts an embedded node with the given index.
+ *
+ * @param testInfo Test info.
+ * @param nodeIndex Index of the node to start.
+ * @param nodesCount the total number of nodes in the cluster.
+ * @return Server registration and future that completes when the node is
fully started and joined the cluster.
+ */
+ public ServerRegistration startEmbeddedNode(
Review Comment:
It is accessed externally in GG code. Should we let it remain public here,
as part of the API? One less friction point during merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
