ivanzlenko commented on code in PR #6774:
URL: https://github.com/apache/ignite-3/pull/6774#discussion_r2439409705
##########
modules/compatibility-tests/src/testFixtures/java/org/apache/ignite/internal/IgniteCluster.java:
##########
@@ -334,34 +352,18 @@ private ServerRegistration startEmbeddedNode(
return new ServerRegistration(node, registrationFuture);
}
- private List<RunnerNode> startRunnerNodes(String igniteVersion, int
nodesCount, List<String> extraIgniteModuleIds) {
- try (ProjectConnection connection = GradleConnector.newConnector()
- .forProjectDirectory(getProjectRoot())
- .connect()
- ) {
- BuildEnvironment environment =
connection.model(BuildEnvironment.class).get();
-
- File javaHome = environment.getJava().getJavaHome();
-
- Set<String> dependencyIds = new HashSet<>();
- dependencyIds.add(IGNITE_RUNNER_DEPENDENCY_ID);
- dependencyIds.addAll(extraIgniteModuleIds);
-
- String dependenciesListNotation = dependencyIds.stream()
- .map(dependency -> dependency + ":" + igniteVersion)
- .collect(joining(","));
+ private void startRunnerNodes(String igniteVersion, int nodesCount,
List<String> extraIgniteModuleIds) {
+ try (ProjectConnection connection = getProjectConnection()) {
+ File javaHome = getJavaHome(connection);
+ File argFile = getArgsFile(connection, igniteVersion,
extraIgniteModuleIds);
- File argFile = constructArgFile(connection,
dependenciesListNotation, false);
-
- List<RunnerNode> result = new ArrayList<>();
for (int nodeIndex = 0; nodeIndex < nodesCount; nodeIndex++) {
String nodeName =
clusterConfiguration.nodeNamingStrategy().nodeName(clusterConfiguration,
nodeIndex);
String nodeConfig = formatConfig(clusterConfiguration,
nodeName, nodeIndex, nodesCount);
- result.add(RunnerNode.startNode(javaHome, argFile,
igniteVersion, clusterConfiguration, nodeConfig, nodesCount, nodeName));
+ runnerNodes.add(
+ RunnerNode.startNode(javaHome, argFile, igniteVersion,
clusterConfiguration, nodeConfig, nodesCount, nodeName));
Review Comment:
The last comment remains
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
