sashapolo commented on code in PR #6799:
URL: https://github.com/apache/ignite-3/pull/6799#discussion_r2438467988
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/compaction/Compactor.java:
##########
@@ -92,6 +94,9 @@ public class Compactor extends IgniteWorker {
private final PartitionDestructionLockManager
partitionDestructionLockManager;
+ /** Latch for pausing and resuming the compaction, {@code null} if there
was no pause. */
+ private final AtomicReference<CountDownLatch> pauseLatchRef = new
AtomicReference<>();
Review Comment:
My main concern is that an `AtomicReference` with a `Latch` does not look
like the most obvious solution to the problem. Regarding being non-blocking, I
don't think that it really matters, since both checkpointer and compactor
mostly do IO. You can always prove me wrong with benchmarks, though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
