sashapolo commented on code in PR #6799:
URL: https://github.com/apache/ignite-3/pull/6799#discussion_r2438462879
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/compaction/Compactor.java:
##########
@@ -396,6 +403,8 @@ void mergeDeltaFileToMainFile(
long pageOffset = deltaFilePageStore.pageOffset(pageIndex);
+ pauseCompactionIfNeeded();
Review Comment:
It would be nice to see if it has any benefits, because currently the code
looks complex and brittle. Overall not big deal, though
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/compaction/Compactor.java:
##########
@@ -396,6 +403,8 @@ void mergeDeltaFileToMainFile(
long pageOffset = deltaFilePageStore.pageOffset(pageIndex);
+ pauseCompactionIfNeeded();
Review Comment:
It would be nice to see if it has any benefits, because currently the code
looks complex and brittle. Overall not a big deal, though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
