tkalkirill commented on code in PR #6799:
URL: https://github.com/apache/ignite-3/pull/6799#discussion_r2438492904
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/compaction/Compactor.java:
##########
@@ -396,6 +403,8 @@ void mergeDeltaFileToMainFile(
long pageOffset = deltaFilePageStore.pageOffset(pageIndex);
+ pauseCompactionIfNeeded();
Review Comment:
What do you mean in general or specifically with the loop?
I tested this approach when investigating the reasons for slow installation
of multiple raft snapshots. Overall, the time it takes to write dirty pages at
a checkpoint became twice as fast for 800+ dirty pages, and file fsyncing sped
up by ~20%.
I don't have any confirmation for the loop; I'm just going by intuition that
it's better to slow down each IO operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
