tkalkirill commented on code in PR #6799:
URL: https://github.com/apache/ignite-3/pull/6799#discussion_r2438443653
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/compaction/Compactor.java:
##########
@@ -396,6 +403,8 @@ void mergeDeltaFileToMainFile(
long pageOffset = deltaFilePageStore.pageOffset(pageIndex);
+ pauseCompactionIfNeeded();
Review Comment:
It would be good to give IOps to the checkpoint, so I placed it before each
disk operation.
If we do it at the beginning of the cycle, we might get fewer IOps. It might
be a bit paranoid, but I think it's better to increase the granularity.
I will add documentation to the `pauseCompactionIfNeeded`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
