ivanzlenko commented on code in PR #6774:
URL: https://github.com/apache/ignite-3/pull/6774#discussion_r2443988753
##########
modules/compatibility-tests/src/testFixtures/java/org/apache/ignite/internal/IgniteCluster.java:
##########
@@ -112,24 +112,66 @@ public void start(String igniteVersion, int nodesCount,
List<String> extraIgnite
throw new IllegalStateException("The cluster is already started");
}
- runnerNodes = startRunnerNodes(igniteVersion, nodesCount,
extraIgniteModuleIds);
+ startRunnerNodes(igniteVersion, nodesCount, extraIgniteModuleIds);
}
/**
* Starts cluster in embedded mode with nodes of current version.
*
* @param nodesCount Number of nodes in the cluster.
+ *
+ * @return a list of server registrations, one for each node.
+ */
+ public List<ServerRegistration> startEmbeddedPreInitialized(int
nodesCount) {
+ return startEmbeddedPreInitialized(null, nodesCount);
+ }
+
+ /**
+ * Starts cluster in embedded mode with nodes of current version.
+ *
+ * @param testInfo Test info.
+ * @param nodesCount Number of nodes in the cluster.
+ *
+ * @return a list of server registrations, one for each node.
+ */
+ public List<ServerRegistration> startEmbeddedPreInitialized(
Review Comment:
Let's leave it as startEmbedded and it can be void.
##########
modules/compatibility-tests/src/testFixtures/java/org/apache/ignite/internal/IgniteCluster.java:
##########
@@ -112,24 +112,66 @@ public void start(String igniteVersion, int nodesCount,
List<String> extraIgnite
throw new IllegalStateException("The cluster is already started");
}
- runnerNodes = startRunnerNodes(igniteVersion, nodesCount,
extraIgniteModuleIds);
+ startRunnerNodes(igniteVersion, nodesCount, extraIgniteModuleIds);
}
/**
* Starts cluster in embedded mode with nodes of current version.
*
* @param nodesCount Number of nodes in the cluster.
+ *
+ * @return a list of server registrations, one for each node.
+ */
+ public List<ServerRegistration> startEmbeddedPreInitialized(int
nodesCount) {
+ return startEmbeddedPreInitialized(null, nodesCount);
+ }
+
+ /**
+ * Starts cluster in embedded mode with nodes of current version.
+ *
+ * @param testInfo Test info.
+ * @param nodesCount Number of nodes in the cluster.
+ *
+ * @return a list of server registrations, one for each node.
+ */
+ public List<ServerRegistration> startEmbeddedPreInitialized(
+ @Nullable TestInfo testInfo,
+ int nodesCount
+ ) {
+ List<ServerRegistration> nodeRegistrations = startEmbedded(testInfo,
nodesCount);
+
+ for (ServerRegistration registration : nodeRegistrations) {
+ assertThat(registration.registrationFuture(),
willCompleteSuccessfully());
+ }
+
+ started = true;
+
+ return nodeRegistrations;
+ }
+
+ /**
+ * Starts cluster in embedded mode with nodes of current version.
+ *
+ * @param nodesCount Number of nodes in the cluster.
+ *
+ * @return a list of server registrations, one for each node.
*/
- public void startEmbedded(int nodesCount, boolean initCluster) {
- startEmbedded(null, nodesCount, initCluster);
+ public List<ServerRegistration> startEmbedded(int nodesCount) {
+ return startEmbedded(null, nodesCount);
}
/**
* Starts cluster in embedded mode with nodes of current version.
*
+ * @param testInfo Test info.
* @param nodesCount Number of nodes in the cluster.
+ *
+ * @return a list of server registrations, one for each node.
*/
- public void startEmbedded(@Nullable TestInfo testInfo, int nodesCount,
boolean initCluster) {
+ public List<ServerRegistration> startEmbedded(
Review Comment:
Let's name it startEmbeddedNotInitialized or something along those lines
##########
modules/compatibility-tests/src/testFixtures/java/org/apache/ignite/internal/IgniteCluster.java:
##########
@@ -112,24 +112,66 @@ public void start(String igniteVersion, int nodesCount,
List<String> extraIgnite
throw new IllegalStateException("The cluster is already started");
}
- runnerNodes = startRunnerNodes(igniteVersion, nodesCount,
extraIgniteModuleIds);
+ startRunnerNodes(igniteVersion, nodesCount, extraIgniteModuleIds);
}
/**
* Starts cluster in embedded mode with nodes of current version.
*
* @param nodesCount Number of nodes in the cluster.
+ *
+ * @return a list of server registrations, one for each node.
+ */
+ public List<ServerRegistration> startEmbeddedPreInitialized(int
nodesCount) {
Review Comment:
Let's leave it as startEmbedded and it can be void.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
