ivanzlenko commented on code in PR #6774:
URL: https://github.com/apache/ignite-3/pull/6774#discussion_r2443996360
##########
modules/compatibility-tests/src/testFixtures/java/org/apache/ignite/internal/IgniteCluster.java:
##########
@@ -173,27 +207,39 @@ public void stop() {
LOG.info("Shut the embedded cluster down");
- if (runnerNodes != null) {
- List<String> nodeNames = runnerNodes.stream()
- .map(RunnerNode::nodeName)
- .collect(toList());
+ List<String> nodeNames = runnerNodes.stream()
+ .map(RunnerNode::nodeName)
+ .collect(toList());
- LOG.info("Shutting the runner nodes down: [nodes={}]", nodeNames);
+ LOG.info("Shutting the runner nodes down: [nodes={}]", nodeNames);
- runnerNodes.parallelStream().forEach(RunnerNode::stop);
- runnerNodes.clear();
+ runnerNodes.parallelStream().forEach(RunnerNode::stop);
+ runnerNodes.clear();
- LOG.info("Shutting down nodes is complete: [nodes={}]", nodeNames);
- }
+ LOG.info("Shutting down nodes is complete: [nodes={}]", nodeNames);
started = false;
stopped = true;
}
+ /**
+ * Init a cluster running in embedded mode. Only required if this has not
been done before in a prior run.
+ *
+ * @param nodeRegistrations list of server registrations.
+ * @param initParametersConfigurator the consumer to use for configuration.
+ */
+ public void initEmbedded(List<ServerRegistration> nodeRegistrations,
Consumer<InitParametersBuilder> initParametersConfigurator) {
Review Comment:
You need either to mark cluster as running here or in the start method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
