korlov42 commented on code in PR #6649:
URL: https://github.com/apache/ignite-3/pull/6649#discussion_r2450730652
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/network/PartitionReplicationMessageGroup.java:
##########
@@ -218,6 +220,16 @@ public interface PartitionReplicationMessageGroup {
*/
short CHANGE_PEERS_AND_LEARNERS_ASYNC_REPLICA_REQUEST = 28;
+ /**
+ * Message type for {@link GetEstimatedSizeWithLastModifiedTsRequest}.
+ */
+ short GET_ESTIMATED_SIZE_WITH_MODIFIED_TS_MESSAGE_REQUEST = 29;
+
+ /**
+ * Message type for {@link GetEstimatedSizeWithLastModifiedTsResponse}.
+ */
+ short GET_ESTIMATED_SIZE_WITH_MODIFIED_TS_MESSAGE_RESPONSE = 30;
Review Comment:
I think, these messages should not be part of partition replication group.
The rule of thumb here: you add message to this group if you will be using
`ReplicaService` as client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
