AMashenkov commented on code in PR #6649:
URL: https://github.com/apache/ignite-3/pull/6649#discussion_r2464951398
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/statistic/SqlStatisticManagerImpl.java:
##########
@@ -196,25 +227,48 @@ private void
onLwmChanged(ChangeLowWatermarkEventParameters parameters) {
List<DestroyTableEvent> events =
destructionEventsQueue.drainUpTo(earliestVersion);
events.forEach(event -> tableSizeMap.remove(event.tableId()));
+ events.forEach(event -> droppedTables.remove(event.tableId()));
}
/** Timestamped size. */
- private static class ActualSize {
- long timestamp;
+ static class ActualSize {
+ long modificationCounter;
long size;
- ActualSize(long size, long timestamp) {
- this.timestamp = timestamp;
+ ActualSize(long size, long modificationCounter) {
+ this.modificationCounter = modificationCounter;
this.size = size;
}
- long getTimestamp() {
- return timestamp;
+ public long modificationCounter() {
+ return modificationCounter;
}
long getSize() {
return size;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+
+ ActualSize that = ((ActualSize) o);
+
+ return modificationCounter == that.modificationCounter && size ==
that.size;
+ }
+
+ @Override
+ public int hashCode() {
+ int result = (int) size;
+ result = 31 * result + (int) modificationCounter;
+ return result;
Review Comment:
```suggestion
return Objects.hash(modificationCounter, size);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
