korlov42 opened a new pull request, #6932: URL: https://github.com/apache/ignite-3/pull/6932
https://issues.apache.org/jira/browse/IGNITE-26984 In case the table is constantly recreated, partition awareness (PA) indeed may request assignment for already dropped table due to the PA metadata caching. However, this is expected, and client must handle such case gracefully. The problem seems to be a race between exceptional completion of `org.apache.ignite.internal.client.table.ClientTable.PartitionAssignment#partitionsFut` and check for assignments validness `org.apache.ignite.internal.client.table.ClientTable#isPartitionAssignmentValid`. I was unable to write test to cover this case, but patch can be validated manually. For this, modify `org.apache.ignite.internal.client.table.ClientTable#isPartitionAssignmentValid` to remove `!pa.partitionsFut.isCompletedExceptionally()` and complete `PartitionAssignment#partitionsFut` manually with any exception. Proposed solution is to ignore any error during PA node derivation. The rational is that PA is best effort anyway, and it has self-healing mechanisms, so valid PA metadata will be available on the next execution. Additionally this patch invalidates cache entries both for PA metadata and table in case of error. ------------- Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ### The Review Checklist - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following: \- There is a single JIRA ticket related to the pull request. \- The web-link to the pull request is attached to the JIRA ticket. \- The JIRA ticket has the Patch Available state. \- The description of the JIRA ticket explains WHAT was made, WHY and HOW. \- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue. - [ ] **Design:** new code conforms with the design principles of the components it is added to. - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable. - [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed. - [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources. ### Notes - [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
