xtern commented on code in PR #6932:
URL: https://github.com/apache/ignite-3/pull/6932#discussion_r2512950580
##########
modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientSql.java:
##########
@@ -365,10 +366,18 @@ private <T> PayloadReader<AsyncResultSet<T>>
payloadReader(
assert table != null;
+ PaCacheKey key = new PaCacheKey(statement);
mappingProviderCache.put(
- new PaCacheKey(statement),
+ key,
PartitionMappingProvider.create(
- table, partitionAwarenessMetadata
+ table,
+ partitionAwarenessMetadata,
+ th -> {
+ if (th instanceof TableNotFoundException) {
Review Comment:
Maybe it's worth logging other exceptions?
My thoughts are as follows: we're currently handling
`TableNotFoundException`, but we don't know what other exceptions might occur.
If we enable logging, on the one hand, we'll be able to diagnose some other
problem immediately, but on the other hand, the user might start seeing spam in
their logs.
If the user is bothered by spam, we can advise him to temporarily disable
partition awareness by changing the cache size to 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
