dant3 commented on code in PR #7320:
URL: https://github.com/apache/ignite-3/pull/7320#discussion_r2651478860
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemoryMetrics.java:
##########
@@ -17,17 +17,40 @@
package org.apache.ignite.internal.pagememory.persistence;
+import java.util.concurrent.TimeUnit;
+import org.apache.ignite.internal.metrics.DistributionMetric;
+import org.apache.ignite.internal.metrics.HitRateMetric;
import org.apache.ignite.internal.metrics.IntGauge;
import org.apache.ignite.internal.metrics.LongAdderMetric;
import org.apache.ignite.internal.metrics.LongGauge;
import
org.apache.ignite.internal.pagememory.configuration.PersistentDataRegionConfiguration;
/** Persistent page memory metrics. */
-class PersistentPageMemoryMetrics {
+class PersistentPageMemoryMetrics implements PageCacheMetrics {
+ private static final long[] PAGE_ACQUIRE_NANOS = {
+ 500, // 500ns - L3 cache hit
+ 1_000, // 1µs - memory access, cache hit
Review Comment:
I removed the first one, it seems to be redundant. You can't tell the
difference anyways
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
